Add env values for local run to allow moving away from Rails.secrets #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…which is to be deprecated
MuriloDalRi
approved these changes
Nov 22, 2024
|
@syed-ali-tw Do you still want to merge this? Personally I think this PR should be closed and the relevant changes made in the Publisher repo. You don’t need to set the SECRET_KEY_BASE. In development and test the value is randomly generated and stored in a temporary file in Footnotes |
|
@syed-ali-tw Can we close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails.application.secrets is deprecated in favor of Rails.application.credentials and and will be removed in Rails 7.2.
This generates alot of warning noise with test runs.
We dont necessarily need Rails.application.credentials and we can just replace the values to be read from environment variables.